Skip to content

Correctly render mermaid digrams inside details blocks

Simon Knox requested to merge psi-mermaid-details into master

What does this MR do?

Issue: #28495 (closed)

Only render Mermaid diagrams when they become visible.

Previously they were being rendered when collapsed, which gave them a computed width/height 0 (they inherited default SVG size of 16x16

Screenshots

Video showing a comment with 4 diagrams. One (outside details block) is rendered upfront. Second one is rendered when details block is expanded. Other 2 are rendered when other details block is expanded, along with the text 'great'.

Screen_Recording_2020-01-28_at_11.20.31_am

Does this MR meet the acceptance criteria?

Conformity

Edited by Simon Knox

Merge request reports

Loading