Skip to content

Do not show 'NaN files' in diff stats when a MR diff does not have any changes.

Manoj M J requested to merge fix-nan-no-diff into master

What does this MR do?

It appears that we have recently started parsing the diff size to int, so if the size is null as returned by the API, parsing this would make it NaN and hence UI breaks. I'm trying to fix it 🤞🏼

Screenshots

Before:

Screenshot_2020-01-30_at_10.00.06_PM

After:

Screenshot_2020-01-30_at_9.59.33_PM

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Manoj M J

Merge request reports

Loading