Skip to content

Updated sizes for gl-loading-icon

Emily Ring requested to merge er-gl-loading-icon-bug-fix into master

What does this MR do?

I am working on updating tests and am unable to render some components due to this error:

Icon sizes 1 - 5 are deprecated, please use 'sm', 'md' and 'lg' instead.

I discovered the error was from the component: gl-loading-icon

I’ve changed the icon sizes based on recommendations I found in a similar issue: gitlab-foss#58598 (moved)

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Merge request reports

Loading