Skip to content

Add `design_note_pin` component

Tom Quirk requested to merge design-note-pin-component into master

What does this MR do?

Implements design_note_pin.vue component.

Why?:

  • Consolidates some partially duplicated markup
  • Enables better testability of this

Importantly, this is roughly part 1/3 of work towards #34353 (closed),

Screenshots

Screenshots added to show that no user-facing change introduced

Before After
revealScreen_Shot_2020-02-03_at_5.11.33_pm
revealScreen_Shot_2020-02-03_at_5.11.33_pm

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by 🤖 GitLab Bot 🤖

Merge request reports

Loading