Return nil license if Gitaly is down
What does this MR do?
When exploring projects (/explore
, /explore/projects/starred
, /explore/projects/trending
), a small license icon is displayed for "MIT", "GNU," etc. That license requires a Gitaly call, so if Gitaly is unreachable or down, the entire page will return a 503. This MR should return nil
, or an empty license so that the page doesn't require it in order to load.
Screenshots
When Gitaly is available:
When Gitaly is unavailable:
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Closes #199442 (closed)
Edited by Thong Kuah