Skip to content

WIP: Remove project / container from repository, blob, commit

DO NOT MERGE

What does this MR do?

Stops carrying a container / project along with ::Repository, ::Commit, and ::Blob instances.

Instead, ::Repository takes the shard name, and ::Commit and ::Blob take the repository.

Things that definitely need to change:

  • Commit#gpg_commit
  • Commit#merge_requests
  • Commit#notes
  • CommitCollection#initialize
  • Repository#initialize_raw_repository
  • RepositoryCache#initialize / RepositorySetCache#initialize (needs project.id to build cache keys right now)
  • Blob#external_storage
  • EE::Blob#owners
  • SnippetBlobPresenter

Screenshots

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Closes #201886 (closed)

Edited by 🤖 GitLab Bot 🤖

Merge request reports

Loading