Add `:read_board` to GroupPolicy
What does this MR do?
Group boards can be read if you're allowed to read the group (:read_group
permission). However projects use a permission, :read_board
. Since the underlying functionality is mostly common, it helps having the same permission checks when possible.
The need for this arose from !22497 (merged), where we're adding querying boards using GraphQL. Having a common permission type to check for a board makes the definitions much cleaner, rather than having to check for :read_board
for projects, and :read_group
for groups.
So added the :read_board
permission, which ends up being a sub permission of :read_group
Related to issue #36756 (closed)
Screenshots
Does this MR meet the acceptance criteria?
Conformity
- [-] Changelog entry
- [-] Documentation (if required)
-
Code review guidelines -
Merge request performance guidelines -
Style guides - [-] Database guides
- [-] Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team