Skip to content

Avoid double credential encoding

Kassio Borges requested to merge kborges/avoid-double-credential-encoding into master

What does this MR do?

Currently the project import_data credential is being double encoded, once before saving the credential, on #import_url=, and again when serving the url on #import_url.

To avoid this behavior the credential will be decoded the credential before saving it, this way we ensure to save the raw credential on the database.

References

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team
Edited by Kassio Borges

Merge request reports

Loading