Skip to content

Redact push options from error logs

Stan Hu requested to merge sh-sanitize-pipeline-params into master

When an error creating a pipeline occurs, we log all the pipeline parameters, including the push options, in an error log and in Sentry. However, since push options are flattened into unique keys (e.g. merge_request.label=gitlab-ci, ci.variable.MY_VARIABLE=test), it's easy to generate many unique keys, which may exceed the Elasticsearch default limit of 1000.

To avoid this from happening, this commit drops the push_options field from the log. These generally shouldn't be needed to understand why a pipeline failed to create.

Closes #202129 (closed)

Merge request reports