Skip to content

Speed up expanding/collapsing diff files

Simon Knox requested to merge psi-diff-dedupe into master

What does this MR do?

Halve the time it takes to collapse diff files.

Basically just inlining one component inside another one.

Move diff_cell_contents into the wrapper component to save excessive Vue instances on the page. Since there are multiple diff_cells for each line of a diff file, there were thousands of these on large files.

Also move spec to jest

Screenshots

Perf trace showing expanding/collapsing a 440 line diff file twice.

Before (6s) After (2.9s)
Screen_Shot_2020-02-07_at_3.00.46_pm Screen_Shot_2020-02-07_at_2.59.50_pm

Does this MR meet the acceptance criteria?

Conformity

Assists #26693 (closed)

Edited by Simon Knox

Merge request reports

Loading