Skip to content

Fix validation of project_key

Jan Provaznik requested to merge fix-prject-key into master

What does this MR do?

!24063 (merged) added a new project_key attribute to service desk settings. This attribute will be used in future to customize incoming email address, but it's optional and can be left empty.

Because it can be left empty, we should skip uniqueness validation if the attribute is not set.

This is a regression because now service desk settings form can not be saved because it will always fail on validation that project key has already been taken.

Screenshots

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Jan Provaznik

Merge request reports

Loading