Drop bridge on any downstream pipeline errors
What does this MR do?
Related to: #198354 (closed)
This MR solves a bug where we don't fail the bridge job for all possible downstream pipeline errors. We previously were checking for the presence of pipeline.yaml_errors
but this only catches config errors and not runtime errors such as: all jobs were filtered out by workflow:rules
or other policies, or specific child.yml
file don't exist, etc.
This MR does not contain any spec changes because it's already covered by existing specs: https://gitlab.com/gitlab-org/gitlab/-/blob/d5e7370a7835222b86f5dca923f34f68ac49c063/ee/spec/services/ci/create_cross_project_pipeline_service_spec.rb#L244
Screenshots
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team