Skip to content

Do not add '@' after an empty ssh_user

Jouke Witteveen requested to merge joukewitteveen/gitlab:empty_ssh_user into master

What does this MR do?

Continuing omnibus-gitlab#4954, I think it is meaningful to be conceptually correct and only add the '@'-sign if there is a nonempty username.

This MR does to ssh_user what is already done for ssh_host: both can now be differentiated from their non ssh-prefixed counterparts. Next, it does not add '@' in front of the hostname if there will not be any username in front of the hostname, mimicking what is already done for the port number.

With this MR in place, it is possible to suppress the username in the ssh_path_prefix simply by setting ssh_user = ''.

Edited by Jouke Witteveen

Merge request reports