Fe top n labels endpoint
What does this MR do?
Fixes #196584 (closed)
- Adds an additional api request for 'top n ranked labels' for a group
- Moves the 'tasksByType.labelIds' state ->
tasksByType.selectedLabelIds
- Moves the
task_by_type_filter
specs to a separate file - Replaces jquery dropdown with
GlNewDropDown
- Updated specs
Requires:
Details
- On load, at most the top N (10) labels should be preselected, the labels will be retrieved from the endpoint in #196582 (closed)
- There should be a max 15 labels that can be selected
- A warning should be displayed if a 16th label is clicked, Possible warning message: "Only 15 labels can be displayed at a time"
UI Changes
- Indicate the max # of labels that can be selected
- 10 labels selected by default
- Less than 10 labels: hide UI n/n labels selected
- 10 - 15 labels: display UI n/n labels selected
- 15 selected - disable selecting new labels
Screenshots
Closed | With labels selected |
---|---|
With more than 10 labels selected | Trying to select a label with max selected |
---|---|
Updated screen recording from @ekigbo |
---|
Screen_Recording_2020-03-06_at_8.33.16_am |
Testing
This MR requires 1 feature flag and 2 license flags to be enabled:
- Feature flag:
tasks_by_type_chart
- Licenses flags:
cycle_analytics_for_groups
,type_of_work_analytics
- you will need to seed cycle analytics data - but there may be some issues: #195829 (closed)
- you might also need to pull the latest gitlab-ui and yarn link to ensure you have gitlab-ui!1141 (merged)
Steps
- Enable the required feature flags, and ensure you have the appropriate license
- Navigate to cycle analytics in the analytics space, ie
http://localhost:3001/-/analytics/value_stream_analytics
- Select the
gitlab org
group from the dropdown - The chart should will render at the bottom of the page
- You might need to adjust the dates to see any results
- Use the filters
-
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Edited by 🤖 GitLab Bot 🤖