Skip to content

Fix order dependent failure on stop_environments_service_spec

Shinya Maeda requested to merge fix-flaky-spec-stop-environments-service into master

What does this MR do?

It seems spec/services/ci/stop_environments_service_spec.rb had a weird test condition that it'll basically never happens.

This MR fixes the condition to a reasonably one, and I've confirmed that it also fixes the order-dependent test failure.

Close #205630 (closed)

Screenshots

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Shinya Maeda

Merge request reports

Loading