Allow the selection of several cards when the cmd or ctrl key is pressed.
What does this MR do?
It's not easy to reproduce but it was an exciting bug to investigate! And I love the theme of the events and their propagations.
It is in fact a conflict between the treatments carried out in the mousedown mousemove and mouseup functions.
Sometimes when we want to select several cards while pressing cmd or ctrl we will unwillingly trigger the mouseMove event after mouseDown and set showDetail to false which will cancel the sending of the 'newDetailIssue' event in the showIssue function.
So I suggest adding a condition in showIssue to allow this event to be sent by moving up the isMultiSelect boolean definition.
Screenshots
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Closes #195969 (closed)