Skip to content

Use a path instead of URL for badge API endpoints

Heinrich Lee Yu requested to merge improve-badge-api-paths into master

What does this MR do?

This makes the badge settings page work even when the host in gitlab.yml is different from the host being used to access the application. We don't really support that setup but I think this is still a good change to make since we don't really need the full URL anyway.

A path is also preferred based on https://docs.gitlab.com/ee/development/fe_guide/frontend_faq.html#5-should-i-use-a-full-url-ie-gongitlab_url-or-a-full-path-ie-gonrelative_url_root-when-referencing-backend-endpoints

This solves a similar problem to #36810 (closed)

Screenshots

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Heinrich Lee Yu

Merge request reports

Loading