Preload associations needed by Namespace#pages_virtual_domain
What does this MR do?
While looking at the performance if the /internal/pages
API endpoint we noticed that there are couple N+1 queries problems:
-
project_feature
when eventually delegatingprivate_pages?
- https://gitlab.com/gitlab-org/gitlab/-/blob/335793d88dca35984d06fa2f62098e2bc3d09000/app/models/pages/lookup_path.rb#L16 -
route
when we callproject.full_path
- https://gitlab.com/gitlab-org/gitlab/-/blob/335793d88dca35984d06fa2f62098e2bc3d09000/app/models/pages/lookup_path.rb#L27
This MR updates Namespace#pages_virtual_domain
to preload project_feature
and route
in order to avoid this.
Related to #207096 (closed).
Screenshots
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Edited by Grzegorz Bizon