Skip to content

Add conditional statement section to FE style guide

Coung Ngo requested to merge cngo/add-conditional-statement-style-section into master

What does this MR do?

This MR adds a new section "Avoid single line conditional statements" to the front end style guide, specifically this page: https://docs.gitlab.com/ee/development/fe_guide/style/javascript.html. This is as a result of the discussion in Slack: https://gitlab.slack.com/archives/C0GQHHPGW/p1582048289052400

Related issues

Author's checklist

Review checklist

All reviewers can help ensure accuracy, clarity, completeness, and adherence to the Documentation Guidelines and Style Guide.

1. Primary Reviewer

  • Review by a code reviewer or other selected colleague to confirm accuracy, clarity, and completeness. This can be skipped for minor fixes without substantive content changes.

2. Technical Writer

  • Optional: Technical writer review. If not requested for this MR, must be scheduled post-merge. To request for this MR, assign the writer listed for the applicable DevOps stage.

3. Maintainer

  1. Review by assigned maintainer, who can always request/require the above reviews. Maintainer's review can occur before or after a technical writer review.
  2. Ensure a release milestone is set.
  3. If there has not been a technical writer review, create an issue for one using the Doc Review template.
Edited by Marcia Ramos

Merge request reports

Loading