Fix variable passthrough in SAST template when using DinD
What does this MR do?
After the introduction of !24108 (merged), variables can't be passed through to the docker run, because of two things happening at the same time:
- Variable expansion in sh -
ENVS=".." docker run $ENVS
will expand$ENVS
in docker run to empty before it evaluates them at the beginning of the line -
$ENVS
passed as literal to docker through quotes, when we want docker run to interpret them as variables to pass.
The solution is to move it into a separate step and removing the quotes, like in this MR.
See the change in action and succeeding job.
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Edited by Catalin Irimie