Show image file size in diff view
What does this MR do?
For #202196 (closed)
This change adds the file size to the single-image diff viewer, which is used when an image is added or deleted.
In theory, it could also be used when a file is renamed, but in practice no image diff is rendered for a renamed file, and instead the text File moved is used instead.
Karma vs. Jest
When I first submitted this MR, a random Karma test was failing only on CI.
As a result of this, I moved the tests to Jest, as @jboyson indicated that had worked to a solve a similar problem of his.
After a bunch of pipeline failures across Karma over the last few days, I'm not confident this move was absolutely necessary - it may have just needed a bunch of rebase and pushes and it would have eventually worked.
That said, the move to Jest didn't introduce too many changes, and it's on our list of things to do anyway, so it would be intentionally creating tech debt to revert it.
Screenshots
| Before | After |
|---|---|
 |
 |
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry - [-] Documentation (if required)
-
Code review guidelines -
Merge request performance guidelines -
Style guides - [-] Database guides
- [-] Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers - [-] Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
- [-] Label as security and @ mention
@gitlab-com/gl-security/appsec - [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
- [-] Security reports checked/validated by a reviewer from the AppSec team