Remove unused code from package controllers
What does this MR do?
Some of the instance variables defined in the project and group package controllers are not being used by the views, so they are unneeded and just adding wasted queries. This MR removes the excess code.
For example, https://gitlab.com/gitlab-org/gitlab/blob/master/ee/app/views/groups/packages/index.html.haml only uses @group
, but the index action in the controller was also defining @packages
.
Screenshots
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Edited by Steve Abrams