Change Jira service to create comments first
What does this MR do?
Issue #195794 (closed)
- As discussed with @nhxnguyen, I wanted to try a speculative fix to the Jira issue to try and create a comment before creating the remote link. This is closer to what the code was doing in %12.5.
- I have also reverted some code to be closer to the original here: https://gitlab.com/gitlab-org/gitlab/-/blob/c77bb71ca5944cdaa6d045ee821c29d809ef2624/app/models/project_services/jira_service.rb#L274. This was from this discussion !26052 (comment 295886903) to fix an old bug.
- As discussed here #198411 (comment 295077110), changed the logging key name to try to avoid the response getting filtered.
Screenshots
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry - [-] Documentation (if required)
-
Code review guidelines -
Merge request performance guidelines -
Style guides - [-] Database guides
- [-] Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers - [-] Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
- [-] Label as security and @ mention
@gitlab-com/gl-security/appsec
- [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
- [-] Security reports checked/validated by a reviewer from the AppSec team
Edited by 🤖 GitLab Bot 🤖