Resolve "Requests for SVGs returning 404 in Issues Analytics feature"
What does this MR do?
This MR passes the SVG path on the Issues Analytics
page for the following empty state illustrations from the BE to the FE:
illustrations/issues.svg
illustrations/monitoring/getting_started.svg
This ensures that the hash (e.g., https://assets.gitlab-static.net/assets/illustrations/issues-b4cb30d5143b86be2f594c7a384296dfba0b25199db87382c3746b79dafd6161.svg
) is appended and avoids SVG loading issues.
In addition, this MR replaces the custom empty state on the Issues Analytics
page with our GlEmptyState
component.
Screenshots
Before | After |
---|---|
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Closes #208479 (closed)
Edited by Martin Wortschack