Skip to content

Move Admin Area Operations menu to top-level

Alishan Ladhani requested to merge ali/move-serverless-to-sidebar into master

What does this MR do?

In !21222 (merged) (originally proposed by #35591 (closed)), we added a new setting to the Admin Area for configuring an instance-level serverless domain. This setting was added under Settings > Operations.

This MR proposes that this setting be moved under a new top-level Operations menu. There are a few reasons for this:

  • All the other settings under Settings are fields on the ApplicationSetting model; Serverless domains do not follow this pattern.
  • Having a top-level Operations menu would make the structure consistent with that of Projects and Groups, which both have serverless settings under Operations > Serverless. For the same reason, we might also consider moving Kubernetes under this new Operations menu.
  • Serverless domains aren't really a setting, so much as they are resources that can be created and destroyed, similar to Kubernetes clusters.

Screenshots

Before:

Screen_Shot_2020-03-23_at_2.21.07_PM

After:

Screen_Shot_2020-03-23_at_2.10.59_PM

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by 🤖 GitLab Bot 🤖

Merge request reports

Loading