Resolve "Use absolute path when unpacking command"
What does this MR do?
Changes the backup manager to stop using basename
when inspecting the BACKUP
env var in favour of using check_path_traversal!
. This means that if someone tries to use a path in BACKUP
they will now get an error, because only a filename is supported as documented here.
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation ([if required](https://docs.gitlab.com/ee/development/documentation/workflow.html#when-documentation-is-required)) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Closes #33773 (closed)
Edited by Vijay Hawoldar