Skip to content

Remove unnecessary Jira template test

Andy Schoenen requested to merge remove_unnecessary_jira_template_test into master

What does this MR do?

This MR removes a test that is not needed because services that where created from a template doesn't behave different from other project services. When a template is applied to a project it copies all attributes to a new service and sets template = false and project_id to the ID of the project.

A service should not be a template and attached to a project at the same time. To simulate a template applied to a project we would need to use Projects::CreateService. But this test would not belong to services_controller_spec.

The test was originally introduced in 72b59d6e

In !26563 (merged) I'm adding a validation that for absence of project_id when the service is a template. This test would fail the validation.

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team
Edited by 🤖 GitLab Bot 🤖

Merge request reports

Loading