Skip to content

Fix inconsistent inflection of Ldap module

Heinrich Lee Yu requested to merge zeitwerk-ldap-inflections into master

What does this MR do?

Changes modules to all use Ldap instead of LDAP. We need to do this to prepare us for the switch to Zeitwerk. It expects modules to be inflected the same way throughout the application.

It was actually easier to change Ldap to LDAP but controllers don't work because the router uses ActiveSupport inflections.

We could change the ActiveSupport inflection for this but it would affect multi-word classes like LdapSyncWorker and having to change all these would be a larger change.

This was extracted from !20521 (merged) for easier review

Related to #197345 (closed)

Screenshots

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Heinrich Lee Yu

Merge request reports

Loading