Skip to content

Fix spinner in Create MR dropdown

Justin Ho Tuan Duong requested to merge 209207-spinner-appears-to-be-broken into master

What does this MR do?

Issue #209207 (closed)

After !24917 (merged) changed the loader to the new spinner, there was a visual regression with an extra icon showing in the spinner. This MR removes the JS that adds the icon.

Screenshots

Browser Before After
Firefox Screen_Shot_2020-03-06_at_23.13.30 Screen_Shot_2020-03-06_at_23.08.28
Chrome Screen_Shot_2020-03-06_at_23.14.34 Screen_Shot_2020-03-06_at_23.18.45

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by 🤖 GitLab Bot 🤖

Merge request reports

Loading