Skip to content

GraphQL: Migrate from the TimeoutMiddleware to the Timeout plugin

Brett Walker requested to merge bw-graphql-timeout-plugin into master

What does this MR do?

The GraphQL gem has unofficially deprecated the Graphql::Schema::TimeoutMiddleware class in favor of Interpreter support for timeouts.

Due to https://github.com/rmosolgo/graphql-ruby/pull/2622 the middleware has become more difficult to test (!26378 (comment 301960574)), so it may be a good time to migrate to the plugin style.

Related to #207278 (closed)

Screenshots

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Brett Walker

Merge request reports

Loading