Skip to content

Rate limits: Cross-link docs and tweak UI wording

Michael Kozono requested to merge mk/update-rate-limit-docs into master

What does this MR do?

Cross-link rate limit docs and tweak UI wording.

From #29952 (comment 241670651):

I've added a couple small to do items.

  • Remove A web server restart is required after changing these settings.

I believe the new Admin Area Protected Paths don't need a web server restart.

I believe Omnibus Protected Paths require a restart because you modify gitlab.rb then reconfigure, which regenerates the initializer, which must be loaded again.

  • Change Omnibus Protected Paths throttle is active. to Omnibus Protected Paths throttle is active, and takes priority over these settings.

Since it doesn't matter whether the Admin Area settings are enabled or not, when this message is being displayed.

Screenshots

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by 🤖 GitLab Bot 🤖

Merge request reports

Loading