Skip to content

Expand redacting search to include non ES results

Dmitry Gruzd requested to merge 36438-expand-redacting-logic into master

What does this MR do?

This is an MR moved from a security project https://gitlab.com/gitlab-org/security/gitlab/-/merge_requests/227 because this is not a security vulnerability and because we don't need backports.

We extend redacted_search_results feature to postgres and gitaly searches.

Before showing search results we check if user has read access to every object. If user doesn't have a valid access, we filter out these results and log that for debugging and alerting purposes.

https://gitlab.com/gitlab-org/gitlab/issues/36438

Screenshots

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Closes #36438 Closes #207940 Closes #210011 (closed)

Edited by 🤖 GitLab Bot 🤖

Merge request reports

Loading