Expand redacting search to include non ES results
What does this MR do?
This is an MR moved from a security project https://gitlab.com/gitlab-org/security/gitlab/-/merge_requests/227 because this is not a security vulnerability and because we don't need backports.
We extend redacted_search_results
feature to postgres and gitaly searches.
Before showing search results we check if user has read access to every object. If user doesn't have a valid access, we filter out these results and log that for debugging and alerting purposes.
https://gitlab.com/gitlab-org/gitlab/issues/36438
Screenshots
Does this MR meet the acceptance criteria?
Conformity
- [-] Changelog entry
- [-] Documentation (if required)
-
Code review guidelines -
Merge request performance guidelines -
Style guides - [-] Database guides
-
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. - [-] Tested in all supported browsers
- [-] Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Closes #36438 Closes #207940 Closes #210011 (closed)
Edited by 🤖 GitLab Bot 🤖