Preserve date filters in analytics
requested to merge 207045-preserve-date-filters-in-value-stream-and-productivity-analytics into master
What does this MR do?
- Fixes the issue with date filters not being preserved when changing filters for both productivity analytics and value stream analytics
- Moves url parameter updating to a shared mixin
- Updates tests to reflect use of the shared mixin
Screenshots
No visual changes
Testing
Productivity analytics
- Navigate to
/-/groups/gitlab-org/-/analytics/productivity_analytics
- Select a group
- Select project / update date ranges
- The query parameters should change
- Change the group, date ranges should still be in the query parameters
Value stream analytics
- Navigate to
/-/analytics/value_stream_analytics
- Select a group
- Select project / update date ranges
- The query parameters should change
- Change the group, date ranges should still be in the query parameters
Comparison
- Switch to your master branch
- Repeat the above processes
- The date filters will disappear when you change filters
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Closes #207045 (closed)
Edited by Ezekiel Kigbo