Skip to content

Remove Admin > Settings > Templates from sidenav when insufficient license

What does this MR do?

Issue #210456 (closed)

When the Templates feature is not included in the license, we should not be showing the link in the sidebar since it will lead to an empty page (because ee/app/views/admin/application_settings/_templates.html.haml is guarded by an if clause with the same condition). This MR removes the Admin > Settings > Templates link when a license does not include the custom_file_templates feature (currently GitLab Premium and above).

Screenshots

What the feature looks like (before)

Screen_Shot_2020-03-13_at_11.50.45

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by 🤖 GitLab Bot 🤖

Merge request reports

Loading