Skip to content

Refactor UpdateDashboardService to remove catch/throw

Kirstie Cook requested to merge 208174-refactor-update-dashboard-service into master

What does this MR do?

#208174 (closed) involves adding a step to the UpdateDashboarsService to create a merge request, and in order to do this nicely and return helpful responses this service needed refactoring. An added bonus is eliminating the catch/throw, which a cop was recently added for in !25990 (merged).

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team

Merge request reports

Loading