Move the vuex logic out of the filter component
What does this MR do?
This refactor does a few things:
It moves all the Vuex logic out of the <filter>
component used on the security dashboards.
Some of this functionality has been pulled into the component as computed properties.
The rest of it, has been moved up to the <filters>
component.
As a result of this, there's some redundant getters that have been removed.
The <filters>
spec has been migrated to Jest with some extra testing.
It even introduces the fancy new <gl-sprintf>
component into the mix.
If all goes well, no one will ever notice these wonderful changes. Everything should continue as normal.
Does this MR meet the acceptance criteria?
Conformity
- [-] Changelog entry
- [-] Documentation (if required)
-
Code review guidelines -
Merge request performance guidelines -
Style guides - [-] Database guides
-
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers - [-] Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Closes #210334 (closed)
Edited by Sam Beckham