Use default_scope for CommitStatus
What does this MR do?
This MR fixes the following deprecation warning:
DEPRECATION WARNING: Class level methods will no longer inherit scoping from `match_id_and_lock_version` in Rails 6.1. To continue using the scoped relation, pass it into the block directly. To instead access the full set of models, as Rails 6.1 will, use `CommitStatus.unscoped`, or `CommitStatus.default_scoped` if a model has default scopes. (called from block (2 levels) in <class:CommitStatus> at /Users/aakriti/Development/my-gdk/gitlab/app/models/commit_status.rb:69)
Screenshots
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team