Fixes stop_review job upon expired artifacts from previous stages
What does this MR do?
This allows for review environments to be stopped after the review artifacts have expired.
Problem:
The review job creates an artifact, specifically environment_url.txt
. Job artifacts have a set period before they are removed. After the job artifacts are removed, the stop_review job cannot run because of the artifact dependency.
Solution: Explicitly define the stop_review job from having any dependencies.
Screenshots
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry - [-] Documentation (if required)
- [-] Code review guidelines
- [-] Merge request performance guidelines
- [-] Style guides
- [-] Database guides
- [-] Separation of EE specific content
Availability and Testing
- [-] Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process.
- [-] Tested in all supported browsers
- [-] Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
- [-] Label as security and @ mention
@gitlab-com/gl-security/appsec
- [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
- [-] Security reports checked/validated by a reviewer from the AppSec team
Edited by Jack Lei