Skip to content

Fix broken links in some Instance-level integrations

What does this MR do?

Issue #210528 (closed)

We are going to allow users to setup integrations (previously called project services) on the instance (admin) level. This is going to live alongside Service Templates and once all is stable, we will deprecate Service Templates.

This MR fixes a few of the integrations that give errors on the instance-level due to some code being dependent on @project.

  • Copy changes in the help text for Mattermost slash commands / Slack slash commands integrations.
  • Fix form paths to use re-usable methods across project / admin.
  • Fix Alerts integration to be display with placeholders.
  • Hide integration button on Slack application integration.

Screenshots

Integration Project Admin
Alerts Screen_Shot_2020-04-06_at_13.50.46 Screen_Shot_2020-04-06_at_13.51.30
Mattermost slash commands Screen_Shot_2020-04-06_at_13.52.37 Screen_Shot_2020-04-06_at_13.53.08
Slack slash commands Screen_Shot_2020-04-06_at_13.53.36 Screen_Shot_2020-04-06_at_13.54.01
Slack application Screen_Shot_2020-04-06_at_13.55.19 Screen_Shot_2020-04-06_at_13.54.33

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by 🤖 GitLab Bot 🤖

Merge request reports

Loading