Extract Ci::Processable::Dependencies class
What does this MR do?
Related to #209070 (closed)
I order to move dependencies logic up to Ci::Processable
I've decided to take an extra step and extract out all that responsibility into a dedicated class.
This new class takes in input a processable (build or bridge) and returns a list of dependencies:
Ci::Processable::Dependencies.new(build).all
Motivation
While trying to move all the methods related to dependencies I realized that there is a lot of cohesive code that was in a class with too many responsibilities. Now all the calculation related to dependencies is in one place.
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Edited by Fabio Pitino