Skip to content

Fix Gitaly Sidekiq timings in Prometheus

Sean McGivern requested to merge fix-gitaly-sidekiq-timings-prometheus into master

What does this MR do?

The RequestStoreMiddleware runs 'inside' the ServerMetrics middleware, so by the time ServerMetrics is done with its yield, the RequestStore doesn't exist any more.

This is exactly the reason why the InstrumentationLogger middleware stores some values in the payload, so use that instead.

Right now, these values are clearly wrong: gitlab-com/gl-infra/scalability#123 (comment 304490934)

Merge request reports