Refactor additional Geo Node tests
What does this MR do?
In an effort for MVC this moves a few of the testing file refactors into its own MR from: !27624 (merged)
This is the same as !27150 (merged) but with different files in the same folder.
Currently in the above mentioned MR, GlPopover was implemented. However, when doing a full mount
of that component there are tons of errors stating: popover cannot find target element
. After troubleshooting for quite awhile I found every usage in GitLab is using shallowMount
.
Since these tests weren't explicitly needing to do a full mount
anyway, I decided to rewrite them using shallowMount
.
The biggest blocker was these tests were written without vue-test-utils
so I had to do a little extra leg work to rewrite them using it. This change got big enough to warrant a separate MR.
Important Notes
I tried my best to not touch any of the tests themselves but rather just work them into shallowMount
. If there are gaps in the tests that already exist, I would ask we create a separate issue to tackle them.
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Closes #209262 (closed)