Revert has_parent? optimization
What does this MR do?
This reverts optimization made in !17749 (merged)
The reason is that at the moment parent_id reference integrity is not assured and a couple of errors were reported when the referenced parent was actually missing (see related issue).
I considered fixing specifically the reported error - check in first_auto_devops_config
if parent
is not nil, but this wouldn't fix the underlying issue and the same problem might pop up elsewhere.
Created #212144 (closed) to re-enable this when possible.
Closes #36938 (closed)
Screenshots
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Edited by Jan Provaznik