Skip to content

Add (IssuableFinder|IssuesFinder)::Params class

Mario de la Ossa requested to merge refactor_issuable_finder into master

What does this MR do?

Add IssuableFinder::Params and IssuesFinder::Params classes.

These classes clearly separate the finder methods from param helper methods, making the IssuableFinder and IssuesFinder classes much cleaner.

This new Params class will be used in an upcoming refactor of the way we do negative searches (!=) to separate the positive context from the negative context.

Screenshots

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Merge request reports

Loading