Add (IssuableFinder|IssuesFinder)::Params class
What does this MR do?
Add IssuableFinder::Params
and IssuesFinder::Params
classes.
These classes clearly separate the finder methods from param helper methods, making the IssuableFinder and IssuesFinder classes much cleaner.
This new Params class will be used in an upcoming refactor of the way we do negative searches (!=
) to separate the positive context from the negative context.
Screenshots
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team