Fix the 'review-deploy' job when RA deployment is manual
What does this MR do?
- Always make the
review-deploy
job manual. - Move
review-build-cng
to thereview
stage so thatreview-build-cng
andreview-deploy
can be started without the other being done first. - Always try to trigger
review-deploy
at the end ofreview-build-cng
. - In
review-deploy
:- If
review-build-cng
is not started, start it. - Wait for
review-build-cng
to finish. - Proceed to deployment.
- At the end, play
review-qa-smoke
andreview-performance
.
- If
- In
review-qa-smoke
andreview-performance
, wait forreview-deploy
to be finished, then download itsenvironment_url.txt
artifact.
Note that #31264 (closed) would allow to avoid most if not all of these workarounds.
Validation
With no frontend change, no deploy
-
The review-build-cng
andreview-deploy
jobs are playable: https://gitlab.com/gitlab-org/gitlab/pipelines/131907868 -
Pipeline shouldn't be stuck in the Running
state
review-deploy
first
With no frontend change, playing -
Play review-deploy
: https://gitlab.com/gitlab-org/gitlab/-/jobs/500096800-
Expect review-build-cng
to be played first -
Expect to wait for review-build-cng
to be done before proceeding to the deploy -
Expect review-qa-smoke
andreview-performance
to be played at the end ofreview-deploy
-
-
Expect review-qa-smoke
andreview-performance
to pass
review-build-cng
first
With no frontend change, playing -
Play review-build-cng
: https://gitlab.com/gitlab-org/gitlab/-/jobs/500543494-
Expect review-deploy
to be played at the end ofreview-build-cng
-
Expect review-qa-smoke
andreview-performance
to be played at the end ofreview-deploy
-
-
-
Expect review-qa-smoke
andreview-performance
to pass
With a frontend change (so that Review App deployment is automatic
-
Expect review-build-cng
to start automatically: https://gitlab.com/gitlab-org/gitlab/-/jobs/492379779-
Expect review-deploy
to be played at the end ofreview-build-cng
-
-
Expect review-qa-smoke
andreview-performance
to start automatically afterreview-deploy
is done -
Expect review-qa-smoke
andreview-performance
to pass
Closes #212354 (closed).
Edited by Rémy Coutable