Skip to content

Fix the 'review-deploy' job when RA deployment is manual

Rémy Coutable requested to merge 212354-fix-review-deploy into master

What does this MR do?

  1. Always make the review-deploy job manual.
  2. Move review-build-cng to the review stage so that review-build-cng and review-deploy can be started without the other being done first.
  3. Always try to trigger review-deploy at the end of review-build-cng.
  4. In review-deploy:
    1. If review-build-cng is not started, start it.
    2. Wait for review-build-cng to finish.
    3. Proceed to deployment.
    4. At the end, play review-qa-smoke and review-performance.
  5. In review-qa-smoke and review-performance, wait for review-deploy to be finished, then download its environment_url.txt artifact.

Note that #31264 (closed) would allow to avoid most if not all of these workarounds.

Validation

With no frontend change, no deploy

  1. The review-build-cng and review-deploy jobs are playable: https://gitlab.com/gitlab-org/gitlab/pipelines/131907868
  2. Pipeline shouldn't be stuck in the Running state

With no frontend change, playing review-deploy first

  1. Play review-deploy: https://gitlab.com/gitlab-org/gitlab/-/jobs/500096800
    1. Expect review-build-cng to be played first
    2. Expect to wait for review-build-cng to be done before proceeding to the deploy
    3. Expect review-qa-smoke and review-performance to be played at the end of review-deploy
  2. Expect review-qa-smoke and review-performance to pass

With no frontend change, playing review-build-cng first

  1. Play review-build-cng: https://gitlab.com/gitlab-org/gitlab/-/jobs/500543494
    1. Expect review-deploy to be played at the end of review-build-cng
      1. Expect review-qa-smoke and review-performance to be played at the end of review-deploy
  2. Expect review-qa-smoke and review-performance to pass

With a frontend change (so that Review App deployment is automatic

  1. Expect review-build-cng to start automatically: https://gitlab.com/gitlab-org/gitlab/-/jobs/492379779
    1. Expect review-deploy to be played at the end of review-build-cng
  2. Expect review-qa-smoke and review-performance to start automatically after review-deploy is done
  3. Expect review-qa-smoke and review-performance to pass

Closes #212354 (closed).

Edited by Rémy Coutable

Merge request reports

Loading