Prefer HTTP status matcher over `response.status`
What does this MR do?
This follow-up MR to #196163 (closed) (where we started to enforce named HTTP status codes in specs) ensures that we prefer the HTTP matcher instead of response.status
.
Example
Bad
expect(response.status).to eq(200)
expect(response.status).not_to eq(200)
Good
expect(response).to have_gitlab_http_status(:ok)
expect(response).not_to have_gitlab_http_status(:ok)
Offenses
This MR also fixes all new offenses in one go.
7069 files inspected, 269 offenses detected
Does this MR meet the acceptance criteria?
Conformity
- [-] Changelog entry
-
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides - [-] Database guides
-
Separation of EE specific content
Availability and Testing
- [-] Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process.
- [-] Tested in all supported browsers
- [-] Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
- [-] Label as security and @ mention
@gitlab-com/gl-security/appsec
- [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
- [-] Security reports checked/validated by a reviewer from the AppSec team
Edited by Peter Leitzen