Enable log explorer to use the full height of the screen
What does this MR do?
Fix for #210502 (closed) and #211507 (closed)
Previously a hardcoded height for the log explorer was set to 600px, in large screens this was too small, and it should adjust in larger (and smaller) screens.
Roughly based on how the issue board keeps and adjustable screen height, with an additional using some flex-column to complete the effect and stretch the logs viewer along with the screen.
Screenshots
Large screens (uses full height)
large (15") | xl (27") |
---|---|
Small screens (when scrolling inside the page is still needed)
Technical Notes
<gl-alert>
?
Why move to For this layout to work in different screen sizes, we must know the height of the elements above the logs viewer container. The header and breadcrumb must have a known height.
For this reason, flash()
was replaced with <gl-alert>
so can be placed inside the logs viewer container. The dismiss action imitates the behavior of flash()
, so no significant UX changes are expected.
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry - [-] Documentation (if required)
-
Code review guidelines - [-] Merge request performance guidelines
-
Style guides - [-] Database guides
- [-] Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Related to #210502 (closed)