LDAP auth support for admin mode
What does this MR do?
Enable LDAP authentication for admin mode, by adding the same tabbed approach as the main devise login forms:
- Delegate all forms to the devise partials for code reuse
- Support potential multiple LDAP providers
- 2FA support is also tested
Extra functionality that should work since they are Omniauth providers and the views now include the appropriate references, but untested:
- Kerberos
- Crowd
- Smartcard Auth
Closes #212434 (closed)
/cc @bufferoverflow @rpaik @reprazent @ifarkas
Screenshots
LDAP user
Standard Gitlab user
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Edited by Diego Louzán