The source project of this merge request has been removed.
Fix duplicated tag deletion activity and events
What does this MR do?
This MR fixes Issue #212969 (closed)
When a release tag is deleted, it creates double activity entries and also double webhook/service notifications if the project is configured with webhook/service integrations.
Currently, this is what happens when a tag is deleted:
- Tags::DestroyService calls
repository.rm_tag
and calls project hooks and executes events. Call torm_tag
invokes GitalyUserDeleteTagRequest
- Gitaly posts back to
/internal/post_receive
API which invokesPostReceive
worker -
PostReceive
worker invokesTagHooksService
which calls the same hooks/services again
This MR removes the project hooks and services call in Tags::DestroyService which is no longer needed.
Screenshots
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Edited by Sashi