Skip to content

Adding preference for execute over call in Service classes

What does this MR do?

Adds that execute is preferred to call in Service classes.

This gives reviewers/maintainers documentation to link to when calling out this preference in a code review.

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Russell Dickenson

Merge request reports

Loading